Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replay: replace QCommandLineParser with getopt for command-line argument parsing. #33812

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Oct 18, 2024

resolve #33813

@github-actions github-actions bot added the tools label Oct 18, 2024
@deanlee deanlee changed the title Refactor tools/replay: Eliminate Qt Dependency replay: replace QCommandLineParser with getopt for command-line argument parsing. Oct 18, 2024
@maxime-desroches
Copy link
Contributor

replay -h does not work anymore:

batman:~/openpilot/tools/replay$ ./replay -h
./replay: invalid option -- 'h'

@maxime-desroches
Copy link
Contributor

Can we keep the old behavior of displaying the help if no flags are given?

@deanlee deanlee marked this pull request as draft October 19, 2024 03:55
@deanlee deanlee marked this pull request as ready for review October 19, 2024 04:12
@deanlee
Copy link
Contributor Author

deanlee commented Oct 19, 2024

fixed

@maxime-desroches maxime-desroches merged commit debd71e into commaai:master Oct 19, 2024
16 checks passed
@deanlee deanlee deleted the replay_use_getopt branch October 19, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor tools/replay: Eliminate Qt Dependency
2 participants